Proposal: pipx run --inspect script.py #1457
Draft
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftnext
commented
Jun 18, 2024
|
|
||
|
|
||
| @mock.patch("pipx.commands.run.exec_app") | ||
| def test_run_inspect(exec_app, tmp_path): |
Author
There was a problem hiding this comment.
I think it is difficult to use execvpe_mock in this (python -i) case.
I will appreciate your comment about this test implementation.
Member
There was a problem hiding this comment.
It’d be quite difficult to actually test this. I would be satisfied if this just mock out the actual process invocation and just chheck the right flags are passed to the child process.
Member
|
I wonder if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1456
changelog.d/(if the patch affects the end users)Summary of changes
Test plan
Tested by running