#1069 Pipe pip progress to pipx #1640
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.d/(if the patch affects the end users)Summary of changes
Refactor
pipx.util.run_subprocessto usesubprocess.Popeninstead, to let us stream terminal output.Send captured output stream to
pipx.animate.animateand forward topipx.animate.print_animatewhere it is included in the printed animation output.HELP
I am not sucessfull in getting the progress-bars themselves from the pip output. I would appreciate som input on if that is necessary, or if this added information is enough to consider #1069 solved? (It does not pipe progress bars, but the spirit of the issue is that it is dfficult to understand if the installation is stuck or just slow).
If this is sufficient, it should just be a matter of deciding on which
with animatecalls it should be included.Test plan
Run pipx install to verify output manually, and make sure all test suites pass.
To test, run: