Skip to content

Conversation

@fluzzywuzzy
Copy link
Contributor

@fluzzywuzzy fluzzywuzzy commented May 18, 2025

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Refactor pipx.util.run_subprocess to use subprocess.Popen instead, to let us stream terminal output.
Send captured output stream to pipx.animate.animate and forward to pipx.animate.print_animate where it is included in the printed animation output.

HELP
I am not sucessfull in getting the progress-bars themselves from the pip output. I would appreciate som input on if that is necessary, or if this added information is enough to consider #1069 solved? (It does not pipe progress bars, but the spirit of the issue is that it is dfficult to understand if the installation is stuck or just slow).

If this is sufficient, it should just be a matter of deciding on which with animate calls it should be included.

Test plan

Run pipx install to verify output manually, and make sure all test suites pass.

To test, run:

# pipx install {PACKAGE_NAME}

@fluzzywuzzy fluzzywuzzy marked this pull request as ready for review June 3, 2025 08:11
@fluzzywuzzy fluzzywuzzy force-pushed the 1069-pipe-pip-progress-bar branch from b35b941 to bb4ca59 Compare June 3, 2025 08:37
@fluzzywuzzy
Copy link
Contributor Author

fluzzywuzzy commented Jun 3, 2025

*Force pushed a commit to overwrite previous with the same name, as replaced commit accidentally deleted file: test_run.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant