feat: add --upgrade and --upgrade-strategy options #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds the `--upgrade` option to `inject` and `install`, mirroring the pip install option - Adds `--upgrade-strategy` to `upgrade` as well as all subcommands where `--upgrade` has been added
Author
|
Maintainers: This PR is not fully complete as tests & docs have not been updated. Seeking approval on my general approach and that this feature is still desired before implementing remaining requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Resolves #1572
--upgradeoption toinjectandinstall, mirroring the pip install option.--upgrade-strategytoupgradeas well as all subcommands where--upgradehas been added above. Upgrade strategy options are the same as pip's whereeagerupgrades all dependencies of the main package regardless of the upgrade being required, andonly-if-neededupgrades only dependencies that require an upgrade.Motivation
Provides a way to conditionally upgrade only if the currently installed version does not match the passed spec. Currently,
pipx upgradeupgrades to the latest available version and does not allow an installation spec.pipx install --upgradeallows this flexibility. This also adds parity with underlying pip commands which is a usability benefit.For example, if I have
blackv24.1.0 installed and I want to upgrade to no higher than the latest minor version of v24 I can now runpipx install --upgrade 'black<25', which was not possible previously.Test plan
PENDING