Skip to content

Conversation

@abravalheri
Copy link
Contributor

@abravalheri abravalheri commented Oct 30, 2025

This is an attempt to fix #5108, even if quick-and-dirty.
It is the most direct/simple change I could think off that would fix the issue in the CI with this test specifically.

Summary of changes

Closes #5108

Pull Request Checklist

@abravalheri abravalheri force-pushed the fix-test_dist_fetch_build_egg branch from b983f04 to 3b0d2d9 Compare October 30, 2025 15:39
@abravalheri
Copy link
Contributor Author

The macOS error is being handled in #5107.

Maybe cygwin will have some problems with formatting instability (old version of ruff).

@Avasam
Copy link
Contributor

Avasam commented Oct 30, 2025

The macOS error is being handled in #5107.

I think you meant #5106 ? (although both are relevant to reference and trying to fix the same issue)

Maybe cygwin will have some problems with formatting instability (old version of ruff).

Ruff install is already skipped on cygwin 😃

setuptools/pyproject.toml

Lines 116 to 121 in 8825a5b

"pytest-ruff >= 0.2.1; sys_platform != 'cygwin'",
# local
# Removal of deprecated UP027, PT004 & PT005 astral-sh/ruff#14383
"ruff >= 0.8.0; sys_platform != 'cygwin'",

@abravalheri abravalheri marked this pull request as ready for review October 30, 2025 17:21
@abravalheri abravalheri merged commit b9d1d55 into pypa:main Oct 30, 2025
54 of 63 checks passed
@abravalheri
Copy link
Contributor Author

Thanks Avasam.

Yes that is correct :P

@abravalheri abravalheri deleted the fix-test_dist_fetch_build_egg branch October 30, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] test_dist_fetch_build_egg failing because it cannot find setuptools 🤔

2 participants