-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "License :: OSI Approved :: NASA Open Source Agreement (NOSA)" #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
requested changes
Feb 22, 2024
If this was already there and I missed it, I will feel rather stupid.
Sorry for wasting everyone's time.
…On Feb 22 2024 12:26 PM, Dustin Ingram wrote:
@di requested changes on this pull request.
> @@ -310,6 +310,7 @@
"License :: OSI Approved :: Mozilla Public License 1.1 (MPL 1.1)",
"License :: OSI Approved :: Mozilla Public License 2.0 (MPL 2.0)",
"License :: OSI Approved :: Mulan Permissive Software License v2
(MulanPSL-2.0)",
+ "License :: OSI Approved :: NASA Open Source Agreement (NOSA)",
```suggestion
"License :: OSI Approved :: NASA Open Source Agreement v1.3
(NASA-1.3)",
```
Per https://opensource.org/license/nasa1-3-php, OSI calls this "NASA
Open Source Agreement v1.3" and the SPDX Identifier is `NASA-1.3`
|
Ah. I misunderstood the point of the comment. I would say that I
approve the change (not sure where I need to do this, but it is OK with
me). I wish I had read this earlier in the day -- NASA's Open Source
Initiative meeting was this afternoon, and I would have been able to get
them to approve of the name or bump it up. They were surprised that it
was named NASA-{ver} instead of NOSA, but I can run this up the chain
and talk to the lawyers who approve the licensing.
I would say for now go with NASA-{ver} as that is what OSI has, and I
will talk to NASA's licensing lawyers to see if they are OK with that or
if I should submit a name change through OSI, et. al.
…
|
do you want me to make these changes and resubmit the pull request? I was confused on what you wanted me to do next. |
@ebo If the change I made is OK with you, we can merge this. |
di
approved these changes
Mar 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Hope you feel better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request to add a new NASA Open Source Agreement (NOSA) classifier:
According to various documentation[*], NOSA is an approved OSI open-source license, but is not contained in any of the online classifier lists.
Inclusion will help facilitate using NOSA in various python projects.