Support passing dist-info-dir to bdist_wheel #612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelson
force-pushed
the
feature/pep517-prepare-metadata-support
branch
2 times, most recently
from
108b218
to
09316a5
Compare
…handle prepare_metadata_for_build_wheel correctly as per PEP-517. Closes pypa#611
pelson
force-pushed
the
feature/pep517-prepare-metadata-support
branch
from
09316a5
to
2f77339
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
==========================================
- Coverage 71.28% 71.04% -0.24%
==========================================
Files 13 13
Lines 1069 1074 +5
==========================================
+ Hits 762 763 +1
- Misses 307 311 +4 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
|
Closing since it is no longer in scope for wheel. (see #611 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support passing dist-info-dir to bdist_wheel, enabling setuptools to handle prepare_metadata_for_build_wheel correctly as per PEP-517. Closes #611
I don't know what the implications of this if the metadata is wildly different - for example, within bdist_wheel there is a filename calculation - currently the metadata used for such calculations is from
egg-info, not from the givendist-info. For my case, that was good enough, and I wasn't able to find a satisfying hook to disableegg-infocalculation, and use that fordistributionmetadata. I would happily take advice on these.