Rewrite `Tensor._sample` to handle `dice_factor` as Delta's `log_density` #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

ordabayevy wants to merge 1 commit into master from tensor-sample

Member

ordabayevy commented Oct 7, 2021 •

edited

Loading

Similar to #551 this rewrites Tensor._sample to place dice_factor into Delta(name, point, dice_factor). In doing so I found it easier:

to do shape manipulations in funsor as much as possible
to sample one variable at a time instead of all variables in the single call


          rewrite Tensor._sample

6708d6b

ordabayevy added WIP low priority labels

ordabayevy marked this pull request as draft

October 27, 2021 20:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

low priority WIP