test: adjust assertion for my_fn_calls based on optax version in test/test_optimizers.py#2140
Merged
Qazalbash merged 4 commits intopyro-ppl:masterfrom Feb 15, 2026
Merged
Conversation
…o-ppl#2137)" This reverts commit 7d67ff5.
…est/test_optimizers.py`
fehiepsi
reviewed
Feb 15, 2026
fehiepsi
approved these changes
Feb 15, 2026
Member
|
Maybe be flexible for optax check and removing version checking? That way the test keeps working if optax behavior changes. |
Collaborator
Author
Do you want a logical statement instead of optax version, like, assert (my_fn_calls == 1) or (my_fn_calls == 2) |
Member
|
Yes, that would be flexible, maybe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fixed the issue related to
optax==0.2.7in #2137. Now flax has pinned the optax version (google/flax#5225), and it is effective in the latestflax==0.12.4. This PR changes the test case modified in #2137 foroptax==0.2.7andoptax<0.2.7(ref: #2134 (comment))