-
-
Notifications
You must be signed in to change notification settings - Fork 993
Update CI Python version to 3.12. #3429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… latest versions of black and ruff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once ci passes. I very much appreciate your maintenance contributions!
@fritzo , last remaining failure is exactly at this line. The unpickled easyguide actually works (the line after the line I mentioned). The error message is
Any idea what is going on here? I'm not sure it is related to Python 3.12. |
@BenZickel I'm not sure what's wrong. Given that @pytest.mark.xfail(reason="https://github.com/pyro-ppl/pyro/issues/XXXXXX") |
…re according to the bug mentioned at pyro-ppl#3430.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @BenZickel!
See #3424 for details.