Skip to content

feat(sequences): add limit and desc params in fetch_sequence_detections #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2025

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Jun 29, 2025

This PR adds new params to the backend endpoint GET /api/v1/sequences/{sequence_id}/detections and the corresponding client method:

  • limit: change the maximum number of items returned (default 10, min 1, max 100)
  • desc: boolean flag specifying whether the result should be ordered by decreasing creation date (default = True)

Copy link

codecov bot commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.94%. Comparing base (b247038) to head (012cbee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   83.94%   83.94%           
=======================================
  Files          39       39           
  Lines        1202     1202           
=======================================
  Hits         1009     1009           
  Misses        193      193           
Flag Coverage Δ
backend 83.25% <ø> (ø)
client 93.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frgfm frgfm marked this pull request as ready for review June 29, 2025 18:43
@frgfm frgfm merged commit c45d5c0 into main Jun 29, 2025
27 checks passed
@frgfm frgfm deleted the frgfm/fetch-seq-dets branch June 29, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant