feat: updated dockerfile to perform poetry installation + requirements automatically#167
Closed
Zougouda wants to merge 1 commit intopyronear:mainfrom
Closed
feat: updated dockerfile to perform poetry installation + requirements automatically#167Zougouda wants to merge 1 commit intopyronear:mainfrom
Zougouda wants to merge 1 commit intopyronear:mainfrom
Conversation
MateoLostanlen
requested changes
Sep 17, 2024
Member
MateoLostanlen
left a comment
MateoLostanlen
left a comment
There was a problem hiding this comment.
Hello @Zougouda , thanks a lot for this pr. Sorry for the late review. I like the change, please can you just adapt the makefile ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version implied to already have a python + poetry installed on the host machine. Which was not very "dockery". I moved the required steps to install all of it in the dockerfile.