ETL Formalization #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonanMorgan
commented
Nov 5, 2024
| # Extract the matched keypoints | ||
| src_pts = np.float32([kp1[m.queryIdx].pt for m in matches]).reshape(-1, 1, 2) | ||
| dst_pts = np.float32([kp2[m.trainIdx].pt for m in matches]).reshape(-1, 1, 2) | ||
| src_pts = np.float32([kp1[m.queryIdx].pt for m in matches]).reshape(-1, 1, 2) # type: ignore |
Collaborator
Author
There was a problem hiding this comment.
I didn't succeed to fix this cleanly @MateoLostanlen , if you want to take a look to avoid ignoring the errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR you will find :
=> a Dockerfile which create a container with all the scripts used in the ETL
=> a Makefile which contains the command launching the ETL
=> a new script to load images from wildfire in our API (thanks to modification in the Engine code)
=> a new script which is creating two configurations files for Wildfire. They should be used with the init_script contained in the pyro-devops repo
There is still many ways to improve the behavior but I think it could be added later :
=> we can set up the crontab and the whole ETL with ansible
=> we can keep the images downloaded during some time if we need to do some check on it afterward
=> we can modify the scripts in order to take a date in input if we need to launch the ETL at a given time (maybe not really interesting for this Wildfire use case since it only keep the images for some date) ?
=> improve CI & tests (I will do it in Novembre)
Since the ETL is pretty small @MateoLostanlen do you think we could run it in a github Action ?