adding alternative option in local_moran and moral_local_rate #205
Conversation
|
These look like useful changes. Thanks. It would be helpful to add test coverage for new/changed functionality and update the documentation to surface these changes/enhancements. |
esda/moran.py
Outdated
| @@ -509,9 +509,7 @@ def by_col( | |||
| def Moran_BV_matrix(variables, w, permutations=0, varnames=None): | |||
| """ | |||
| Bivariate Moran Matrix | |||
|
|
|||
There was a problem hiding this comment.
It seems that your editor removed blank lines in the docstring. Can you please put them back (all of them)?
esda/moran.py
Outdated
| @@ -889,6 +875,9 @@ class Moran_Local(object): | |||
| value to use as a weight for the "fake" neighbor for every island. If numpy.nan, | |||
| will propagate to the final local statistic depending on the `stat_func`. If 0, then | |||
| the lag is always zero for islands. | |||
| alternative: string | |||
There was a problem hiding this comment.
| alternative: string | |
| alternative: {"two-tailed", "one-tailed"} | |
| (default="two-tailed") |
This follows the pattern used above.
esda/moran.py
Outdated
| possible values -> "one-tailed"/ "two-tailed" | ||
| default value ->"two-tailed" |
There was a problem hiding this comment.
this part should contain a description of what the argument controls, i.e. what does it mean if I use "one-tailed" vs "two-tailed". Does not have to be detailed but just a hint, an explanation in plain words. Like in permutations, where we say "number of random permutations for calculation of pseudo p_values".
|
@martinfleis @sjsrey , could you please tell me how to add test coverage for local_moran and moran_local_rate, |
|
Hey! this is looking very good, well done @tushar-corbic!
Sure! Normally, we add a method to the test class for that module. For |
Thank you @ljwolf , |
No description provided.