Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geopandas-base in 312-min.yaml #347

Closed
wants to merge 1 commit into from
Closed

geopandas-base in 312-min.yaml #347

wants to merge 1 commit into from

Conversation

jGaboardi
Copy link
Member

geopandas-base in 312-min.yaml -- xref #346

@jGaboardi jGaboardi added the ci label Aug 6, 2024
@jGaboardi jGaboardi self-assigned this Aug 6, 2024
@martinfleis
Copy link
Member

Still comes with it. libpysal requires geopandas (not geopandas-base).

@jGaboardi
Copy link
Member Author

So:

  • If matplotlib comes with geopandas through libpysal as a hard requirement, then it can't really be an optional one here, right?
  • If it can be, is it even worth trying to figure out how to tests against not having it? I tried several ways of creating a minimum esda environment locally, but each way keeps pulling matplotlib.

@martinfleis
Copy link
Member

We could change the conda-forge recipe to depend on geopandas-base there but I don't think it is worth the hassle.

@jGaboardi
Copy link
Member Author

Closing for now. We can look into again as time/energy permit.

@jGaboardi jGaboardi closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants