-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added function torusW #245
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for integration and to document expected behaviour.
You can add a test in https://github.com/pysal/libpysal/tree/master/libpysal/weights/tests
See other tests in that directory for examples. Let us know if you have questions after that.
I've added a test for the function |
@sjsrey should i instead create a new function for |
@MgeeeeK I think separating this out to its own function, maybe |
✅ Build libpysal 1.0.25 completed (commit c6a3ba2101 by @sjsrey) |
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
=========================================
Coverage ? 81.10%
=========================================
Files ? 116
Lines ? 11633
Branches ? 0
=========================================
Hits ? 9435
Misses ? 2198
Partials ? 0 Continue to review full report at Codecov.
|
✅ Build libpysal 1.0.29 completed (commit 73d5f7a62d by @MgeeeeK) |
@sjsrey new commits contains:
sorry for reopening this pr...i messed up my dev environment earlier so had to drop all my commits. |
nosetests
on your changes?pysal/master
branch.docstrings and
unittests?
reviewer and added relevant labels
torus
and its functionality in functionlat2w
, this fixes the issue pysal/pysal#894