Skip to content

support Colormap object and kwargs in plot_legendgram #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025

Conversation

martinfleis
Copy link
Member

Allow Colormap class alongside string as a cmap and pass kwargs to ax.hist for further customisation. Also includes @QuLogic's comments from #234.

Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.0%. Comparing base (57990b2) to head (2c25144).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #250   +/-   ##
=====================================
  Coverage   90.0%   90.0%           
=====================================
  Files         10      10           
  Lines       1169    1170    +1     
=====================================
+ Hits        1052    1053    +1     
  Misses       117     117           
Files with missing lines Coverage Δ
mapclassify/classifiers.py 88.6% <ø> (ø)
mapclassify/legendgram.py 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi jGaboardi merged commit 8ac07ba into pysal:main May 29, 2025
17 checks passed
@martinfleis martinfleis deleted the lgram-cmap branch May 29, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants