Skip to content

image testing and comparison revamping #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 14, 2025

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Jun 14, 2025

image testing and comparison revamping

This PR:


  • gets CI green
  • omits text/font from image comparison
  • negates the need to skip certain MPL versions
  • CI artifacts can be downloaded from the associated action run summary
    • e.g. here for action run 15655277902 triggered by commit 50531a5

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.0%. Comparing base (741ca5d) to head (f0d4005).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #265     +/-   ##
=======================================
+ Coverage   87.7%   90.0%   +2.3%     
=======================================
  Files         10      10             
  Lines       1170    1170             
=======================================
+ Hits        1026    1053     +27     
+ Misses       144     117     -27     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi jGaboardi marked this pull request as ready for review June 14, 2025 19:21
Co-authored-by: Martin Fleischmann <[email protected]>
@jGaboardi jGaboardi merged commit ded496a into pysal:main Jun 14, 2025
17 checks passed
@jGaboardi jGaboardi deleted the GH259_image_test_passing branch June 14, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants