Skip to content

MAINT: add more pytest.approx calls #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

cjwatson
Copy link
Contributor

These tests failed on Debian i386, probably due to x87 excess precision: https://bugs.debian.org/1103140

These tests failed on Debian i386, probably due to x87 excess precision:
https://bugs.debian.org/1103140
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.2%. Comparing base (4037c70) to head (ed03a44).
Report is 111 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #698     +/-   ##
=======================================
+ Coverage   97.4%   98.2%   +0.8%     
=======================================
  Files         26      40     +14     
  Lines       4328    7164   +2836     
=======================================
+ Hits        4214    7033   +2819     
- Misses       114     131     +17     
Files with missing lines Coverage Δ
momepy/tests/test_dimension.py 100.0% <100.0%> (ø)
momepy/tests/test_intensity.py 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martinfleis martinfleis merged commit c9fb1bd into pysal:main Apr 22, 2025
15 checks passed
@cjwatson cjwatson deleted the more-approx branch April 22, 2025 12:40
@martinfleis
Copy link
Member

@cjwatson do you need a release?

@cjwatson
Copy link
Contributor Author

I think we can just cherry-pick that patch. No urgency about a release unless you were planning on doing one anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants