handle scipy deprecation #91
Conversation
| @@ -1,4 +1,4 @@ | |||
| scipy>=0.11 | |||
| scipy>=1.8.0 | |||
There was a problem hiding this comment.
| scipy>=1.8.0 | |
| scipy>=1.7.0 |
We have 1.7.4 in the CI and it works as expected.
There was a problem hiding this comment.
Scipy bumped from v1.7.3 to v1.8.0 without having intermediate releases. So I think scipy>=1.8.0 and scipy>=1.7.4 are equivalent and I do not think v1.7.3 or v1.7.1 works.
There was a problem hiding this comment.
We have 1.7.3 (typo above, sorry) here https://github.com/pysal/pointpats/actions/runs/4320355325/jobs/7540519213 and it works apparently. So 1.7 seems to be enough now I believe.
There was a problem hiding this comment.
This is testing on scipy v1.10.1?
And it seems the deprecations happened in v1.8.0 based on the release note
https://docs.scipy.org/doc/scipy/release.1.8.0.html#clear-split-between-public-and-private-api
There was a problem hiding this comment.
Ah! I missed this. And It also means that I have not done #87 properly. The minimal env should use the pinned versions of SciPy. Not sure why it gets upgraded by pip...
There was a problem hiding this comment.
Nope, I am stupid. It is the change in this PR that is forcing the update.
If 1.8 is the new minimal, can you also update it in the 38-minimal environment? So we really get 1.8 and not 1.10 when we want to test the oldest supported version?
There was a problem hiding this comment.
Just updated the 38-minimal environment
partially address #89
handle scipy's deprecation since v1.8.0:
/Users/runner/work/pointpats/pointpats/pointpats/geometry.py:134: DeprecationWarning: Please use
ConvexHullfrom thescipy.spatialnamespace, thescipy.spatial.qhullnamespace is deprecated.