-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize infrastructure #45
Conversation
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
=======================================
+ Coverage 69.8% 71.7% +1.9%
=======================================
Files 9 8 -1
Lines 999 760 -239
=======================================
- Hits 697 545 -152
+ Misses 302 215 -87
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
@martinfleis I think this PR is ready for review now. I have added the docs and release workflows, event though the release will not work until we get access to |
|
No good deed goes unpunished. 🤣 |
@martinfleis And it's been a long time since I've set up the GH-Pages stuff. Not sure I did it correctly... In Setting/Pages I simply changed the branch to |
I've never done it (momepy still runs on RTD and its own domain) but you'll need to point it to |
Perhaps @knaaptime can advise? But also, once this is reviewed and merged I can simply do some trial and error |
pretty sure the action will create the branch if necessary |
@jGaboardi it seems that you should have all the rights you need to setup the publishing action with a token, right? |
Yep, I just set that up right now. So once this PR is reviewed and merged we can give |
@jGaboardi What is the status here? |
Waiting for a review. |
Co-authored-by: Martin Fleischmann <[email protected]>
This PR:
codecov
config file #44setup.*
forpyproject.toml
setuptools_scm
ruff
lints more strictlypre-commit-config
setup*.*
(and related) filesdocs/{build,generated}*
files (this accounts for the huge file diff)pytest
overunittest
@martinfleis this isn't complete, but how's looking so far? Some questions/comments: