Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add Codecov coverage testing #127

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Conversation

slumnitz
Copy link
Member

  • add Codecov badge to README.md
  • add .codecov.yml after Numpy example

.codecov.yml Outdated Show resolved Hide resolved
@jGaboardi
Copy link
Member

Anything more I can help out with for this?

@slumnitz
Copy link
Member Author

@jGaboardi I'll be sprinting on this again on Monday, would you be interested interested in another work along session like last time? :)

@jGaboardi
Copy link
Member

@jGaboardi I'll be sprinting on this again on Monday, would you be interested interested in another work along session like last time? :)

I'll probably be able to do that and will absolutely join if I can.

@martinfleis
Copy link
Member

@jGaboardi do you recall what needs to be done here (if something)?

@jGaboardi
Copy link
Member

Although not required, I would like to see some changes to .codecov.yml:

  • probably rename to codecov.yml
  • in the notify section increase the after_n_builds value to however many builds are actually being performed
  • add an after_n_builds variable to the comments section (same value as previous bullet)
  • add a range to the coverage section
  • and other details (here is spaghetti's, for example)

@martinfleis
Copy link
Member

@jGaboardi can you push those? It seems you have a clear idea what to do. We'll get it out of the way and make that patch release with #140, which is well overdue.

@jGaboardi
Copy link
Member

Should we also put in another PR for trimming down the CI matrix?

@jGaboardi
Copy link
Member

@martinfleis, Do you want to resolve the README conflicts or shall I?

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both!

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #127 (cacf532) into main (3121b26) will increase coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #127     +/-   ##
=======================================
+ Coverage   75.8%   76.4%   +0.6%     
=======================================
  Files         19      19             
  Lines       1570    1570             
=======================================
+ Hits        1190    1199      +9     
+ Misses       380     371      -9     
Impacted Files Coverage Δ
splot/_version.py 40.7% <0.0%> (+2.7%) ⬆️

@martinfleis martinfleis merged commit 0679125 into pysal:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants