Update build system for CMake 4 and OpenMP 17.0.1 #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates build tooling and dependencies for the SWMM Toolkit, focusing on modernizing CMake usage, updating OpenMP integration, and improving compatibility for macOS builds. The changes improve maintainability and ensure the project uses current best practices for building and linking libraries.
Build system modernization:
swmm-toolkit/CMakeLists.txtfrom 3.17 to 4.0.2, ensuring compatibility with newer CMake features.build-requirements.txt, allowing installation of the latest compatible versions ofsetuptools,wheel,scikit-build, andcmake.OpenMP integration improvements:
extern/openmp.cmaketo use OpenMP 17.0.1 (was 12.0.1), added explicit handling for LLVM CMake modules, and improved target linking and compiler options for better compatibility and maintainability.macOS build compatibility:
setup.pyfrom Ninja to Xcode and updated the deployment target from 10.9 to 11.0, improving support for recent macOS versions.SWIG compile definitions:
outputandsolvertargets insrc/swmm/toolkit/CMakeLists.txtto explicitly set them to empty, which may resolve build warnings or errors related to macro definitions.Submodule update:
swmm-solversubmodule to a newer commit, pulling in the latest changes from the solver codebase.