-
Notifications
You must be signed in to change notification settings - Fork 29
Update wheel build and test workflow #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove unnecessary echo command for PWD.
Removed step to get wheel filename and set a static name for the uploaded artifact.
Remove deployment target specification for macOS in setup.py.
Set MACOSX_DEPLOYMENT_TARGET environment variable for building wheel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request modernizes the build and test workflows by upgrading to newer versions of GitHub Actions, adding Python 3.13 support while dropping Python 3.8, and improving macOS compatibility through environment-based deployment target configuration.
- Updated GitHub Actions to version 5 and added Python 3.13 support while removing Python 3.8
- Configured macOS deployment target through environment variables instead of CMake arguments
- Enhanced build matrix to include ARM64 architecture and improved artifact naming
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/build_wheel.yml |
Updated Actions versions, Python support matrix, macOS environment configuration, and artifact naming |
.github/workflows/unit_test.yml |
Added macOS deployment target environment variable |
swmm-toolkit/setup.py |
Removed hardcoded macOS deployment target from CMake arguments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| uses: actions/checkout@v3 | ||
| with: | ||
| submodules: true | ||
| uses: actions/checkout@v5 |
Copilot
AI
Sep 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkout action is missing the submodules: true configuration that was present in the original version. This could cause build failures if the project depends on git submodules.
| uses: actions/checkout@v5 | |
| uses: actions/checkout@v5 | |
| with: | |
| submodules: true |
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: wheels-linux-aarch64-${{ matrix.pyver }} |
Copilot
AI
Sep 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an extra space after 'name:' in the artifact name. Should be name: wheels-linux-aarch64-${{ matrix.pyver }}
| name: wheels-linux-aarch64-${{ matrix.pyver }} | |
| name: wheels-linux-aarch64-${{ matrix.pyver }} |
This pull request updates the build and test workflows to improve compatibility with newer Python versions and macOS environments, and to streamline artifact handling. The most important changes are grouped below by theme.
Python and GitHub Actions Version Updates:
actions/checkoutandactions/setup-pythonto use version 5 in all workflows for improved reliability and future compatibility. [1] [2]cp313) in wheel builds and cross-wheel builds, while removing support for Python 3.8 (cp38). [1] [2] [3]macOS Build Environment Improvements:
MACOSX_DEPLOYMENT_TARGETto "11.0" in both wheel and unit test workflows to ensure compatibility with newer macOS versions. [1] [2]setup.py, relying on environment configuration instead.Build Matrix and Architecture Updates:
x86_64andarm64for broader compatibility, and updated artifact naming for clarity.Artifact Upload and Naming Improvements:
General Workflow Streamlining:
osmatrix in cross-wheel builds.These updates help ensure the project is ready for newer Python and macOS releases, improve CI reliability, and make build artifacts easier to manage.