-
Notifications
You must be signed in to change notification settings - Fork 29
Dev wheel build #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Dev wheel build #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary echo command for PWD.
Removed step to get wheel filename and set a static name for the uploaded artifact.
Remove deployment target specification for macOS in setup.py.
Set MACOSX_DEPLOYMENT_TARGET environment variable for building wheel.
|
Work flow status: build wheels |
bemcdonnell
approved these changes
Sep 1, 2025
|
@michaeltryby, the wheel is failing for cp313 on windows. I'm not sure why, the error is a complex one, but my first suggesting would be to update the test requirements so we don't build numpy from source for testing. This should work |
|
Thanks @karosc that fixed the build! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the build and test workflows for the project to improve compatibility with newer Python versions and macOS, streamline artifact naming, and adjust architecture support. The most significant changes include updating GitHub Actions versions, expanding Python and architecture coverage, and setting the macOS deployment target for builds and tests.
Workflow and Compatibility Updates:
actions/checkout@v5andactions/setup-python@v5for improved reliability and future compatibility.x86_64andarm64architectures, improving support for Apple Silicon.MACOSX_DEPLOYMENT_TARGETto"11.0"in both wheel build and unit test workflows to ensure compatibility with newer macOS environments. [1] [2]Artifact and Build Process Improvements:
CMAKE_OSX_DEPLOYMENT_TARGETin the macOS build configuration insetup.py, relying on environment variables instead for consistency across workflows.