Skip to content

Conversation

@michaeltryby
Copy link
Collaborator

This pull request removes support for building the OpenMP library on Apple platforms from the SWMM Toolkit build system. The changes simplify the build process by eliminating the custom OpenMP build logic and its associated license file, and update references and dependencies accordingly.

Build system simplification:

  • Removed Apple-specific logic for building the OpenMP library from the main CMakeLists.txt, so OpenMP is now always expected to be provided by the system or found via CMake. (swmm-toolkit/CMakeLists.txt)
  • Removed the custom CMake module for fetching and building the OpenMP library on Darwin (swmm-toolkit/extern/openmp.cmake).
  • Removed the OpenMP license file that was associated with the custom build process (swmm-toolkit/extern/license-llvm-openmp.txt).
  • Updated the solver target to remove conditional linking to the custom OpenMP target, further simplifying the build logic (swmm-toolkit/src/swmm/toolkit/CMakeLists.txt).

General maintenance:

  • Updated project metadata comments in CMakeLists.txt files to reflect the latest modification date. (swmm-toolkit/CMakeLists.txt, swmm-toolkit/src/swmm/toolkit/CMakeLists.txt) [1] [2]
  • Updated the submodule reference for swmm-solver to a newer commit. (swmm-toolkit/swmm-solver)

@michaeltryby michaeltryby self-assigned this Sep 3, 2025
@michaeltryby
Copy link
Collaborator Author

Hey @karosc, I confirmed the OpenMP linkage in libswmm5 packaged in the wheel. Thanks for showing me how to do it!

Copy link
Member

@karosc karosc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All around nice cleanup. I particularly like the library alias and interface aspect of it all. Confirmed the link is working on my end for all platforms.

👏🙏🙇‍♂️

@michaeltryby michaeltryby merged commit 5578c8e into pyswmm:dev Sep 3, 2025
3 checks passed
@michaeltryby michaeltryby deleted the dev-openmp branch September 3, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants