Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always pass config.option to workers #799

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Always pass config.option to workers #799

wants to merge 2 commits into from

Conversation

phnmn
Copy link

@phnmn phnmn commented Jul 27, 2022 •
edited by ssbarnea
Loading

Workers did not share config.option from controller

Fixes: #800

@phnmn phnmn changed the title pass config.option to workers always pass config.option to workers Jul 27, 2022
@phnmn phnmn closed this Jul 28, 2022
@phnmn phnmn deleted the patch-1 branch July 28, 2022 10:35
@phnmn phnmn restored the patch-1 branch July 28, 2022 13:58
@phnmn phnmn reopened this Jul 28, 2022
@ssbarnea ssbarnea changed the title always pass config.option to workers Always pass config.option to workers Aug 23, 2022
@ssbarnea ssbarnea added the bug label Aug 23, 2022
@ssbarnea ssbarnea requested a review from nicoddemus August 23, 2022 20:38
RonnyPfannschmidt
RonnyPfannschmidt reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this was intentionally avoided

Config initialization is incredibly fragile

@nicoddemus
Copy link
Member

@RonnyPfannschmidt want to elaborate on this and/or close the PR?

@RonnyPfannschmidt
Copy link
Member

I currently don't have the bandwidth to pull this together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt left review comments

@ssbarnea ssbarnea ssbarnea approved these changes

@nicoddemus nicoddemus Awaiting requested review from nicoddemus

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workers did not share option from controller
4 participants
@phnmn @nicoddemus @RonnyPfannschmidt @ssbarnea