-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.8 support #12875
Open
Pierre-Sassoulas
wants to merge
15
commits into
pytest-dev:main
Choose a base branch
from
Pierre-Sassoulas:drop-python3.8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Drop python 3.8 support #12875
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
72da822
Upgrade doc and CI after dropping python 3.8
Pierre-Sassoulas f18479a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 10cf221
[pre-commit] Auto-apply pyupgrade py39-plus (manual stage)
Pierre-Sassoulas 0649ece
Enable pylint's python 3.8 typing checks (deprecated-typing-alias)
Pierre-Sassoulas de18341
Enable pylint's python 3.8 typing checks (unnecessary-default-type-args)
Pierre-Sassoulas 94539e8
Remove code that is impossible to reach on python 3.9+
Pierre-Sassoulas 1bb85a5
Fix 'typing.AbstractSet' is deprecated, use 'collections.abc.Set'
Pierre-Sassoulas 87d2135
Fix 'typing.Type' is deprecated, use 'type' instead
Pierre-Sassoulas 0b701eb
Fix 'typing.ContextManager' is deprecated, use 'contextlib.AbstractCo…
Pierre-Sassoulas 62da60e
Clarify comment containing 3.8 in it
Pierre-Sassoulas fe1f3f7
Necessary for the 'test / check' to not fail in CI
Pierre-Sassoulas 6220b45
Update changelog/12874.breaking.rst
Pierre-Sassoulas 35e4404
Merge remote-tracking branch 'upstream/main' into drop-python3.8
Pierre-Sassoulas cbf31bf
Revert "Necessary for the 'test / check' to not fail in CI"
Pierre-Sassoulas 9216e89
fix inconsistencies following review
Pierre-Sassoulas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
We dropped support for python 3.8 following its end of life (2024-10-07) | ||
Pierre-Sassoulas marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some problems:
windows-py39
is used in theinclude
section but is missing innames
ubuntu-py39
is declared innames
but not used ininclude
From my understanding we should use
name
here, as this is the variable we want to match ininclude
-- perhaps the problems happening before were due because of the mismatches above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into it, nice catch !