testing: Explicitly pass -Werror to tests needing it
#13481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly pass `-Werror` to `runpytester()` in the few additional tests needing it, in order to fix test failures when the test suite is run with `-Wdefault` or a similar override. Fixes pytest-dev#13480
psf-chronographer
bot
added
the
bot:chronographer:provided
bluetech
reviewed
Jun 3, 2025
| @@ -211,7 +211,7 @@ def test_it(request): | |||
| """ | |||
| ) | |||
|
|
|||
| result = pytester.runpytest() | |||
| result = pytester.runpytest("-Werror") | |||
There was a problem hiding this comment.
@graingert Does this look good to you?
| @@ -257,7 +257,7 @@ def test_it(): | |||
| ) | |||
|
|
|||
| with _disable_gc(): | |||
| result = pytester.runpytest() | |||
| result = pytester.runpytest("-Werror") | |||
There was a problem hiding this comment.
@graingert Does this look good to you?
testing/test_warnings.py
Outdated
| @@ -169,7 +169,7 @@ def test_my_warning(self): | |||
| assert True | |||
| """ | |||
| ) | |||
| result = pytester.runpytest() | |||
| result = pytester.runpytest("-Werror") | |||
There was a problem hiding this comment.
Hmm seems this one somewhat negates the purpose of the test, which IIUC is meant to pass no matter what. We should check this one... (Will try to do it later)
There was a problem hiding this comment.
I opened #13485 about this. Can you please add a @pytest.mark.skip("issue #13485") on this test for now?
There was a problem hiding this comment.
Sure, done. For the record, I wouldn't mind leaving the test as-is either — we can just deselect it locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly pass
-Werrortorunpytester()in the few additional tests needing it, in order to fix test failures when the test suite is run with-Wdefaultor a similar override.Fixes #13480
If this change fixes an issue, please:
closes #XYZWto the PR description and/or commits (whereXYZWis the issue number). See the github docs for more information.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
Create a new changelog file in the
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.Write sentences in the past or present tense, examples:
Also make sure to end the sentence with a
..Add yourself to
AUTHORSin alphabetical order.