FIX: Update raises.py and tests for new error message #13858
Closed
+55
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses a
TODOinAbstractRaises._check_match(insidesrc/_pytest/raises.py) which noted that the error message for a regex mismatch could be confusing.The previous message used
Regex:andInput:, which could be ambiguous in failure logs.This change updates the
_fail_reasonstring to be more explicit:Regex:->Expected regex:Input:->Actual message:This makes the failure message clearer and easier to debug, as requested in the code comment.
Tests
This change required updating the assertions in several tests that were checking for the exact old error message. The following test files were updated to expect the new, clearer message:
testing/python/raises.pytesting/python/raises_group.py