Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 5, 2025

Created by the prepare release pr workflow.

Once all builds pass and it has been approved by one or more maintainers, start the deploy workflow, using these parameters:

  • Use workflow from: release-9.0.0.
  • Release version: 9.0.0.

Or execute on the command line:

gh workflow run deploy.yml -r release-9.0.0 -f version=9.0.0

After the workflow has been approved by a core maintainer, the package will be uploaded to PyPI automatically.

@bluetech
Copy link
Member

bluetech commented Nov 5, 2025

I will edit the changes later, but any comments welcome in the meantime.

The RTD build has some error in subtests.rst:

/home/docs/checkouts/readthedocs.org/user_builds/pytest/checkouts/13878/doc/en/how-to/subtests.rst:29: WARNING: Lexing literal_block '$ pytest -q test_subtest.py\nuuuuuF                                                               [100%]\n================================= FAILURES =================================\n_______________________ test [custom message] (i=1) ________________________\n\nsubtests = <_pytest.subtests.Subtests object at 0xdeadbeef0001>\n\n    def test(subtests):\n        for i in range(5):\n            with subtests.test(msg="custom message", i=i):\n>               assert i % 2 == 0\nE               assert (1 % 2) == 0\n\ntest_subtest.py:6: AssertionError\n_______________________ test [custom message] (i=3) ________________________\n\nsubtests = <_pytest.subtests.Subtests object at 0xdeadbeef0001>\n\n    def test(subtests):\n        for i in range(5):\n            with subtests.test(msg="custom message", i=i):\n>               assert i % 2 == 0\nE               assert (3 % 2) == 0\n\ntest_subtest.py:6: AssertionError\n___________________________________ test ___________________________________\ncontains 2 failed subtests\n========================= short test summary info ==========================\nSUBFAILED[custom message] (i=1) test_subtest.py::test - assert (1 % 2) == 0\nSUBFAILED[custom message] (i=3) test_subtest.py::test - assert (3 % 2) == 0\nFAILED test_subtest.py::test - contains 2 failed subtests\n3 failed, 3 subtests passed in 0.12s' as "pytest" resulted in an error at token: 'u'. Retrying in relaxed mode. [misc.highlighting_failure]

@nicoddemus
Copy link
Member

The RTD build has some error in subtests.rst:

Seem related to the new u character that is used as short letter for a failed subtest:

uuuuuF                                                               [100%]

We might need to update the pytest highlighter, perhaps @asottile can help?

Otherwise we can change from .. code-block:: pytest to .. code-block:: console and lose the syntax highlighting.

Comment on lines -265 to -267
@pytest.mark.webtest: mark a test as a webtest.
@pytest.mark.slow: mark test as slow.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should not be removed, need to investigate.

no further details known at this point.
========================= short test summary info ==========================
FAILED test_simple.yaml::hello
FAILED test_simple.yaml::hello - usecase execution failed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be expected but I'm not sure, need to check.

=========================== test session starts ============================
platform linux -- Python 3.x.y, pytest-8.x.y, pluggy-1.x.y
rootdir: /home/sweet/project
configfile: pytest.ini
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something's gone wrong here, probably doesn't pick up the config due to the toml/ini change. Are the # content of comments actually directives? I removed some of them. Need to check it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the # content of comments actually directives?

They are directives to regendoc.

$ pytest -q --cmdopt=type3
ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: argument --cmdopt: invalid choice: 'type3' (choose from type1, type2)
inifile: None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement I think. Though maybe we should just omit if None.

=========================== test session starts ============================
platform linux -- Python 3.x.y, pytest-8.x.y, pluggy-1.x.y
rootdir: /home/sweet/project
configfile: pytest.ini
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not have disappeared.

@bluetech
Copy link
Member

bluetech commented Nov 5, 2025

I addressed @nicoddemus's comments and edited the changelog.

The other parts of the diff have some problems I need to check.

@asottile
Copy link
Member

asottile commented Nov 5, 2025

I can take a look at the highlighter later today probably

@bluetech
Copy link
Member

bluetech commented Nov 5, 2025

I tried to fix regendoc to handle nested directives but my simplistic attempt (fiddling with the dedent function) fails on the full pytest docs. regendoc works on the textual level and treats a consecutive sequence of lines with a non-zero indentation (modulo empty lines) to be a "block". That's doesn't handle nesting. Need to think of another approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants