-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Release 9.0.0 #13878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.0.x
Are you sure you want to change the base?
Release 9.0.0 #13878
Conversation
|
I will edit the changes later, but any comments welcome in the meantime. The RTD build has some error in subtests.rst: |
Seem related to the new We might need to update the pytest highlighter, perhaps @asottile can help? Otherwise we can change from |
| @pytest.mark.webtest: mark a test as a webtest. | ||
| @pytest.mark.slow: mark test as slow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should not be removed, need to investigate.
| no further details known at this point. | ||
| ========================= short test summary info ========================== | ||
| FAILED test_simple.yaml::hello | ||
| FAILED test_simple.yaml::hello - usecase execution failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be expected but I'm not sure, need to check.
| =========================== test session starts ============================ | ||
| platform linux -- Python 3.x.y, pytest-8.x.y, pluggy-1.x.y | ||
| rootdir: /home/sweet/project | ||
| configfile: pytest.ini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something's gone wrong here, probably doesn't pick up the config due to the toml/ini change. Are the # content of comments actually directives? I removed some of them. Need to check it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the # content of comments actually directives?
They are directives to regendoc.
| $ pytest -q --cmdopt=type3 | ||
| ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...] | ||
| pytest: error: argument --cmdopt: invalid choice: 'type3' (choose from type1, type2) | ||
| inifile: None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an improvement I think. Though maybe we should just omit if None.
| =========================== test session starts ============================ | ||
| platform linux -- Python 3.x.y, pytest-8.x.y, pluggy-1.x.y | ||
| rootdir: /home/sweet/project | ||
| configfile: pytest.ini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not have disappeared.
c995061 to
2538175
Compare
|
I addressed @nicoddemus's comments and edited the changelog. The other parts of the diff have some problems I need to check. |
|
I can take a look at the highlighter later today probably |
|
I tried to fix regendoc to handle nested directives but my simplistic attempt (fiddling with the |
Created by the prepare release pr workflow.
Once all builds pass and it has been approved by one or more maintainers, start the deploy workflow, using these parameters:
Use workflow from:release-9.0.0.Release version:9.0.0.Or execute on the command line:
gh workflow run deploy.yml -r release-9.0.0 -f version=9.0.0After the workflow has been approved by a core maintainer, the package will be uploaded to PyPI automatically.