More cleanups mostly around config #13880
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already imported from a bunch of places.
The `processopt` callback currently doesn't update any fields, so this code is not needed. And since we definitely do not want to extend the use of `processopt`, it's fine to remove.
Same as in `OptionGroup`, this continues making our Parser code just a simple wrapper around argparse.
It's a low-level concern so low level should handle it. And one less thing in the `_processopt` callback which hopefully we can eventually remove.
As recommended by Python's documentation for `__import__`.
No longer needed, forgot to remove it.
Unlike what the comment says, it is not called multiple times when `--help` is used (it is not used at all when not).
No apparent need for it.
bluetech
force-pushed
the
config-cleanups-3
branch
from
5180e05 to
b6d9eb6
Compare
|
Seems like |
|
Now there is some other error on py310. I will check it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More small internal cleanups, please see the commits. With this, I think argparsing.py is decently clean code.