-
-
Notifications
You must be signed in to change notification settings - Fork 409
Use a fully locked test environment #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
OK, problem number 2 is that we don't have That's a) a bummer because it's nice to test actual wheels, but also b) too much work to work around right now, so I'll get back to it later. |
Problem number 2 has been fixed in tox-uv 1.13! https://github.com/tox-dev/tox-uv/releases/tag/1.13.0 |
d6fa02f to
c66aba9
Compare
c34e7ee to
49b9a17
Compare
aa0551d to
f97daed
Compare
43cf8d4 to
04e7eff
Compare
|
hrhm the failure on 3.8 is AFAICT caused by the fact that tox-uv dropped 3.8 and the older tox-uv versions have no support for groups. Well, let's see how long it take uv to fix the dynamic version problem. |
|
So the final piece appears to be that and: @gaborbernat @charliermarsh do y'all think this is a tox-uv a an uv thing? I can't find a related issue in either bug tracker but I wouldn't be surprised if nobody has tried this with PyPy yet. FWIW, PyPy works perfectly fine without dependency groups/locking. |
|
FTR: if we'd be OK with dropping 3.8, uv has added all the bits and this would be ready to go. |
|
Let's gooo |
3a908cd to
6234f14
Compare
|
FTR: since this PR also introduces dependency groups, we can't merge it until Pip merges support for them. There's gonna be enough noise for depending on an up-to-date Pip version; I'm not ready to deal with the backlash of requiring uv. |
658ab60 to
aad4af9
Compare
d806415 to
f588cfd
Compare
1930562 to
43c0098
Compare
|
Omg stop edging me and merge it already |
|
I need a cigarette |
This is currently more of an open experiment to find out what's missing in uv for FOSS projects.
The first obvious problem is that it locks the local version of the package that changes after every commit (so we can have Test PyPI uploads).