Skip to content

Conversation

@hynek
Copy link
Member

@hynek hynek commented Sep 19, 2024

This is currently more of an open experiment to find out what's missing in uv for FOSS projects.

The first obvious problem is that it locks the local version of the package that changes after every commit (so we can have Test PyPI uploads).

@hynek
Copy link
Member Author

hynek commented Sep 19, 2024

OK, problem number 2 is that we don't have --installpkg anymore.

That's a) a bummer because it's nice to test actual wheels, but also b) too much work to work around right now, so I'll get back to it later.

@hynek
Copy link
Member Author

hynek commented Sep 19, 2024

OK, problem number 2 is that we don't have --installpkg anymore.

That's a) a bummer because it's nice to test actual wheels, but also b) too much work to work around right now, so I'll get back to it later.

Problem number 2 has been fixed in tox-uv 1.13! https://github.com/tox-dev/tox-uv/releases/tag/1.13.0

@hynek hynek force-pushed the uv-lock branch 4 times, most recently from d6fa02f to c66aba9 Compare September 27, 2024 04:03
@hynek hynek force-pushed the uv-lock branch 3 times, most recently from c34e7ee to 49b9a17 Compare October 8, 2024 07:48
@hynek hynek force-pushed the uv-lock branch 2 times, most recently from aa0551d to f97daed Compare October 10, 2024 05:55
@hynek hynek force-pushed the uv-lock branch 4 times, most recently from 43cf8d4 to 04e7eff Compare November 2, 2024 13:59
@hynek
Copy link
Member Author

hynek commented Nov 2, 2024

hrhm the failure on 3.8 is AFAICT caused by the fact that tox-uv dropped 3.8 and the older tox-uv versions have no support for groups. Well, let's see how long it take uv to fix the dynamic version problem.

@hynek
Copy link
Member Author

hynek commented Jan 10, 2025

So the final piece appears to be that uv sync won't sync anything into our PyPy environment:

$ tox -re pypy3-tests
pypy3-tests: remove tox env folder /Users/hynek/FOSS/attrs/.tox/pypy3-tests
pypy3-tests: venv> /Users/hynek/.local/share/uv/tools/tox/bin/uv venv -p pypy3 --allow-existing /Users/hynek/FOSS/attrs/.tox/pypy3-tests
pypy3-tests: uv-sync> uv sync --frozen --no-dev --group tests
pypy3-tests: commands[0]> pytest tests/test_functional.py
pypy3-tests: failed with pytest is not allowed, use allowlist_externals to allow it
  pypy3-tests: FAIL code 1 (1.29 seconds)
  evaluation failed :( (1.35 seconds)

and:

$ ls .tox/pypy3.10-tests/lib/pypy3.10/site-packages/
 _attrs.pth   _virtualenv.pth   _virtualenv.py   attrs-24.3.1.dev11.dist-info

@gaborbernat @charliermarsh do y'all think this is a tox-uv a an uv thing? I can't find a related issue in either bug tracker but I wouldn't be surprised if nobody has tried this with PyPy yet. FWIW, PyPy works perfectly fine without dependency groups/locking.

@hynek
Copy link
Member Author

hynek commented Jan 22, 2025

FTR: if we'd be OK with dropping 3.8, uv has added all the bits and this would be ready to go.

@Tinche
Copy link
Member

Tinche commented Jan 22, 2025

Let's gooo

@hynek hynek force-pushed the uv-lock branch 7 times, most recently from 3a908cd to 6234f14 Compare January 24, 2025 07:11
@hynek
Copy link
Member Author

hynek commented Jan 31, 2025

FTR: since this PR also introduces dependency groups, we can't merge it until Pip merges support for them. There's gonna be enough noise for depending on an up-to-date Pip version; I'm not ready to deal with the backlash of requiring uv.

@hynek hynek force-pushed the uv-lock branch 2 times, most recently from 658ab60 to aad4af9 Compare February 10, 2025 05:07
@hynek hynek force-pushed the uv-lock branch 2 times, most recently from d806415 to f588cfd Compare February 22, 2025 10:28
@hynek hynek force-pushed the uv-lock branch 2 times, most recently from 1930562 to 43c0098 Compare March 6, 2025 19:30
@Tinche
Copy link
Member

Tinche commented Mar 6, 2025

Omg stop edging me and merge it already

@hynek hynek marked this pull request as ready for review May 19, 2025 18:02
@hynek hynek requested a review from Tinche May 19, 2025 18:02
@Tinche
Copy link
Member

Tinche commented May 19, 2025

I need a cigarette

@hynek hynek added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit 00f6ac4 May 19, 2025
19 checks passed
@hynek hynek deleted the uv-lock branch May 19, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants