Skip to content

Propuesta Identidad Visual - Diseño #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Propuesta Identidad Visual - Diseño #124

wants to merge 3 commits into from

Conversation

crizconzeta
Copy link
Contributor

Propuesta original ajustada según lo conversado en la reunión del 29/01.
Idealmente, esta será la base para ir trabajando mejoras durante el año.

image

@crizconzeta crizconzeta requested a review from a team as a code owner January 30, 2025 22:30
@crizconzeta crizconzeta requested review from KrlitosForever, pablolirag, yeriel, ancaneo, Jamadath, Tony-Rome and Ferx096 and removed request for a team January 30, 2025 22:30
@Ferx096
Copy link
Member

Ferx096 commented Jan 30, 2025

Muy bueno

KrlitosForever
KrlitosForever requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@KrlitosForever KrlitosForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente trabajo, sólo me gustaría que se aumentara un poco el tamaño de los hashtag

@crizconzeta @KrlitosForever
Update pycltheme/static/css/cl.css
36b8224 
Agrega sugerencia respecto al tamaño del texto de los tags

Co-authored-by: Carlos Carrasco Varas <[email protected]>
KrlitosForever
KrlitosForever approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@KrlitosForever KrlitosForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchísimas gracias. Excelente Trabajo 🦾

Tony-Rome
Tony-Rome requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@Tony-Rome Tony-Rome left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faltaría actualizar el nombre de la rama, respetando la nomenclatura pch-[tipo]-[numero-issue]-[titulo] por ejemplo: pch-change-123-propuesta-visual

@crizconzeta crizconzeta deleted the pch-propuesta-diseño branch January 31, 2025 22:39
@crizconzeta crizconzeta mentioned this pull request Jan 31, 2025
Merged
@pablolirag
Copy link
Member

El degradado no es estándar en el diseño, se les gusta deben de poner mas degradados como en el botones etc, en caso contrario debe de ser plano como el resto del sitio, Busquen Los 10 Principios de usabilidad web de Jakob Nielsen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tony-Rome Tony-Rome Tony-Rome requested changes

@KrlitosForever KrlitosForever KrlitosForever approved these changes

@pablolirag pablolirag Awaiting requested review from pablolirag pablolirag is a code owner automatically assigned from python-chile/codeowners

@yeriel yeriel Awaiting requested review from yeriel yeriel is a code owner automatically assigned from python-chile/codeowners

@ancaneo ancaneo Awaiting requested review from ancaneo ancaneo is a code owner automatically assigned from python-chile/codeowners

@Jamadath Jamadath Awaiting requested review from Jamadath Jamadath is a code owner automatically assigned from python-chile/codeowners

@Ferx096 Ferx096 Awaiting requested review from Ferx096 Ferx096 is a code owner automatically assigned from python-chile/codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crizconzeta @Ferx096 @pablolirag @KrlitosForever @Tony-Rome