(deprecated) typing - 'gtid.py', 'exceptions.py', 'binlogstream.py' #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: add typing gtid.py & refactor Gtid.__init__ * docs: add typing gtid.py * refactor: update docstring format --------- Co-authored-by: mikaniz <[email protected]>
dongwook-chan
approved these changes
Sep 1, 2023
starcat37
changed the title
…hub.com/23-OSSCA-python-mysql-replication/python-mysql-replication into feature/typing-packet-gtid-binlogstream
…cation/python-mysql-replication into feature/typing-packet-gtid-binlogstream
|
@heehehe 님과 의논했던 내용에 맞춰서 (#79 (comment)) binlogstream.py를 수정해서 곧바로 feature/typing-packet-gtid-binlogstream 브랜치로 push 했습니다..! (b9b241b) 그런데 그러고 나니 main 브랜치와 충돌이 생겨서 충돌을 해결하려고 수정하니 현재 origin/main 브랜치 가장 최근 커밋 내역이 pytest에 실패해서 저희 브랜치도 같이 영향을 받았습니다... (bf73d97) 의도치 않게 브랜치 커밋 내역이 복잡해졌네요ㅠㅠ 죄송합니다...! 혹시 현재 시점에서 고쳐야 하는 사항이 있다면 알려주세요😢😢 |
|
수인님 늦은 시간까지 고생 많으셨습니다ㅠㅠ commit 이력 복잡해진건 rebase squash 통해 해결할 수 있을 것 같아서 제가 테스트 오류나는건 일단 저희쪽 문제가 아니라면 상관없을 것 같긴 한데 살펴보긴 해야겠네요..! |
|
지금 확인해보니 upstream에서는 julien-duponchelle#468 pr이 merge되어서 충돌이 해결된 것으로 보여요...! origin에서도 sync fork 해주고 한 번 더 main에서 가져오면 충돌은 해결될 것 같은데... 커밋 내역이 또 복잡해질 것 같아서 일단 코멘트로만 남겨놓을게요🥲 |
heehehe
changed the title
|
#85 로 새로 올려서 여기 PR은 close 하겠습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
우선 지금까지 구현 완료된 gtid.py / exceptions.py / binlogstream.py 에 대한 PR 올립니다!