Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stream_output): respect FORCE_COLOR #343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(stream_output): respect FORCE_COLOR #343

wants to merge 1 commit into from

Conversation

branchvincent
Copy link
Member

Closes #341

@trag1c
Copy link
Member

trag1c commented Jul 17, 2023

What do you think about including a warning when both NO_COLOR and FORCE_COLOR are supplied (like build does)? 🤔

@Secrus
Copy link
Member

Secrus commented Jul 17, 2023

What do you think about including a warning when both NO_COLOR and FORCE_COLOR are supplied (like build does)? 🤔

I agree, there should be a warning message (even if only for debugging purposes).

@adam-grant-hendry
Copy link

Question: Is this intended to replace the ANSICON environment variable option?

@adam-grant-hendry adam-grant-hendry mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support FORCE_COLOR env var
4 participants
@branchvincent @trag1c @Secrus @adam-grant-hendry