Skip to content

tests: add test for cyclic self-referential dependencies#10489

Merged
radoering merged 1 commit intopython-poetry:mainfrom
radoering:self-ref-extras-test-cyclic-dependency
Aug 9, 2025
Merged

tests: add test for cyclic self-referential dependencies#10489
radoering merged 1 commit intopython-poetry:mainfrom
radoering:self-ref-extras-test-cyclic-dependency

Conversation

@radoering
Copy link
Member

@radoering radoering commented Aug 3, 2025

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Add tests to ensure the dependency solver handles cyclic self-referential extras correctly

Tests:

  • Add a "cyclic" extras group to test_solver_returns_extras_if_requested_in_multiple_groups
  • Add reciprocal "cyclic" and "cyclic2" entries to test_solver_resolves_self_referential_extras to simulate self-referential dependency cycles

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 3, 2025

Reviewer's Guide

This PR enhances the solver’s test suite by introducing scenarios for cyclic self-referential extras, ensuring that the solver can detect and correctly resolve cycles in extra dependency definitions.

File-Level Changes

Change Details Files
Add cyclic extras scenario to group-based extra inclusion tests
  • Insert ("cyclic", ...) case in test_solver_returns_extras_if_requested_in_multiple_groups
tests/puzzle/test_solver.py
Extend self-referential extras resolution tests with cyclic mapping
  • Add "cyclic" and "cyclic2" groups to extras mapping
  • Assert solver resolves the cyclic references and includes base packages
tests/puzzle/test_solver.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @radoering - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering force-pushed the self-ref-extras-test-cyclic-dependency branch from 7a4f5a9 to 2c2c9ab Compare August 9, 2025 11:55
@radoering radoering merged commit af5a7a6 into python-poetry:main Aug 9, 2025
53 checks passed
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2025
@radoering radoering deleted the self-ref-extras-test-cyclic-dependency branch December 13, 2025 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments