Skip to content

fix: adjust virtualenv constraint in pyproject.toml to < 20.33.0 #10491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yonathan-wolloch-lendbuzz
Copy link
Contributor

@yonathan-wolloch-lendbuzz yonathan-wolloch-lendbuzz commented Aug 3, 2025

This is introduced as virtualenv introduced a breaking change to poetry in v20.33.0.

Pull Request Check List

Resolves: #10490

  • Added tests for changed code.
  • Updated documentation for changed code.

@yonathan-wolloch-lendbuzz
Copy link
Contributor Author

@dimbleby as you explained in the issue, it seems that poetry is broken now as there is a logical error in the integration with virtualenv v20.33.0. is it possible to release a fix with the version lock as a hot-fix for now until the complete solution is presented?

@dimbleby
Copy link
Contributor

dimbleby commented Aug 3, 2025

not within my power.

But IMO it would be better to fix poetry to work with the fixed virtualenv, probably by reverting #9413

This is introduced as virtualenv introduced a breaking change to poetry in v20.33.0
@radoering radoering force-pushed the fix-virtualenv-dependency branch from 7e7cd29 to 60198e6 Compare August 4, 2025 15:00
@radoering radoering changed the title fix: adjust virtualenv constraint in pyproject.toml to <= 20.32.0 fix: adjust virtualenv constraint in pyproject.toml to < 20.33.0 Aug 4, 2025
@radoering radoering merged commit 757f648 into python-poetry:main Aug 4, 2025
53 checks passed
radoering pushed a commit that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: poetry is using default python version instead of venv python as result of new version in virtualenv v20.33.0
3 participants