-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Bump dulwich to 0.24.0 and update deprecated API usage #10492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's GuideThis PR upgrades the dulwich dependency to the 0.24.x series and replaces all deprecated direct repository operations with the new WorkTree API, ensuring staging, committing, and index resets use repo.get_worktree(). Class diagram for updated Dulwich WorkTree API usageclassDiagram
class Repo {
+get_worktree() WorkTree
}
class WorkTree {
+reset_index()
}
Repo "1" --o "1" WorkTree : get_worktree()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jelmer - I've reviewed your changes - here's some feedback:
- Consider extracting get_worktree() into a small helper so you can avoid repeating local.get_worktree() and improve readability.
- Audit the codebase for other dulwich API calls (e.g. repo.stage or repo.do_commit) to ensure all deprecated methods have been updated for v0.24.0.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting get_worktree() into a small helper so you can avoid repeating local.get_worktree() and improve readability.
- Audit the codebase for other dulwich API calls (e.g. repo.stage or repo.do_commit) to ensure all deprecated methods have been updated for v0.24.0.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- Update dulwich version constraint from >=0.22.6,<0.23.0 to >=0.24.0,<0.25.0 - Use the new WorkTree API in Dulwich, fixing deprecation warnings
Summary by Sourcery
Bump Dulwich dependency and migrate to its new WorkTree API to resolve deprecation warnings
Enhancements:
Build:
Tests: