fix(oauth2): ACCESS_TOKEN_METHOD defaults to POST #1048
Merged
+5
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
reviewed
Mar 14, 2025
nijel
force-pushed
the
access-token-post
branch
from
6954bd3 to
640ec3e
Compare
This is possibly a breaking change for a few backends but makes the code follow RFC and removes need for every backend to override this. Fixes python-social-auth#284
nijel
force-pushed
the
access-token-post
branch
from
640ec3e to
de015f9
Compare
|
Merged. As mentioned, this might be a breaking change for some backends not following RFC. In case you run into this, set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is possibly a breaking change for a few backends but makes the code follow RFC and removes need for every backend to override this.
Fixes #284
Proposed changes
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
Other information
Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.