Add setting to allow inactive users to login#746
Merged
nijel merged 2 commits intopython-social-auth:masterfrom Sep 18, 2025
Merged
Add setting to allow inactive users to login#746nijel merged 2 commits intopython-social-auth:masterfrom
nijel merged 2 commits intopython-social-auth:masterfrom
Conversation
Contributor
|
Looks good. Can you resolve the file conflict and get the tests running? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #746 +/- ##
==========================================
+ Coverage 78.10% 78.12% +0.01%
==========================================
Files 354 354
Lines 10945 10951 +6
Branches 485 485
==========================================
+ Hits 8549 8555 +6
Misses 2223 2223
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Merged, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #745
Proposed changes
Adds a new settings ALLOW_INACTIVE_USERS_LOGIN and then check this setting on the on_complete method before the utils.user_is_active check.
Types of changes
Please check the type of change your PR introduces:
Checklist
Other information