Skip to content

Add setting to allow inactive users to login#746

Merged
nijel merged 2 commits intopython-social-auth:masterfrom
gabrielfgularte:feature/allow-inactive-users
Sep 18, 2025
Merged

Add setting to allow inactive users to login#746
nijel merged 2 commits intopython-social-auth:masterfrom
gabrielfgularte:feature/allow-inactive-users

Conversation

@gabrielfgularte
Copy link
Contributor

Issue: #745

Proposed changes

Adds a new settings ALLOW_INACTIVE_USERS_LOGIN and then check this setting on the on_complete method before the utils.user_is_active check.

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

@gersona
Copy link
Contributor

gersona commented Dec 18, 2024

Looks good. Can you resolve the file conflict and get the tests running?

@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.12%. Comparing base (eeb467c) to head (e8c9d25).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   78.10%   78.12%   +0.01%     
==========================================
  Files         354      354              
  Lines       10945    10951       +6     
  Branches      485      485              
==========================================
+ Hits         8549     8555       +6     
  Misses       2223     2223              
  Partials      173      173              
Flag Coverage Δ
unittests 78.12% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nijel nijel linked an issue Sep 18, 2025 that may be closed by this pull request
@nijel nijel merged commit dce2585 into python-social-auth:master Sep 18, 2025
11 checks passed
@nijel
Copy link
Member

nijel commented Sep 18, 2025

Merged, thanks for your contribution!

@nijel nijel self-assigned this Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Ability to allow inactive users

3 participants