gh-120619: Strength reduce function guards, support 2-operand instruction forms #124846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidget-Spinner
requested review from
brandtbucher and
markshannon
and removed request for
markshannon
brandtbucher
reviewed
Oct 2, 2024
Fidget-Spinner
changed the title
|
@markshannon can you please bengmchmark this? |
|
No significant performance impact, 0.3% faster on average. |
markshannon
requested changes
Nov 6, 2024
|
When you're done making the requested changes, leave the comment: |
markshannon
requested changes
Nov 7, 2024
brandtbucher
reviewed
Nov 7, 2024
|
Looks good to me. @brandtbucher can you approve if you are happy with the JIT changes? |
brandtbucher
approved these changes
Nov 8, 2024
Co-authored-by: Brandt Bucher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_CHECK_FUNCTION_EXACT_ARGSif we can statically determine the number of arguments at optimization time._CHECK_FUNCTION_VERSIONto not need to read the stack operands. To do this, we need a 2-operand form of uops. This PR thus adds support for that.Altogether, these prepare it for partial evaluation in the future, as after removing these guards, this means the inputs do not need to be materialized.