[3.12] gh-124651: Quote template strings in venv activation scripts (GH-124712)
#126185
+135
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-124712) This patch properly quotes template strings in `venv` activation scripts. This mitigates potential command injection. (cherry picked from commit d48cc82)
|
Please review carefully my backport, I'm not sure of what I did :-) @y5c4l3 @vsajip: Would you mind to review my backport to 3.12? There was a merge conflict on I also backported manually the changes to:
I removed quotes around |
vsajip
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
vsajip
approved these changes
Oct 31, 2024
|
GH-126269 is a backport of this pull request to the 3.11 branch. |
|
Thanks for the review @vsajip! |
pablogsal
pushed a commit
that referenced
this pull request
Nov 1, 2024
ambv
pushed a commit
that referenced
this pull request
Nov 4, 2024
…GH-124712) (GH-126185) (GH-126269) (GH-126300) (cherry picked from commit ae961ae)
ambv
pushed a commit
that referenced
this pull request
Nov 4, 2024
Redent0r
added a commit
to Redent0r/CBL-Mariner
that referenced
this pull request
Nov 6, 2024
Taken from python/cpython#126185 which is a 3.12 backport of python/cpython#124712 Signed-off-by: Saul Paredes <[email protected]>
12 tasks
Redent0r
added a commit
to Redent0r/CBL-Mariner
that referenced
this pull request
Nov 6, 2024
Taken from python/cpython#126185 which is a 3.12 backport of python/cpython#124712 Signed-off-by: Saul Paredes <[email protected]>
Redent0r
added a commit
to Redent0r/CBL-Mariner
that referenced
this pull request
Nov 7, 2024
Taken from python/cpython#126185 which is a 3.12 backport of python/cpython#124712 Signed-off-by: Saul Paredes <[email protected]>
Redent0r
added a commit
to Redent0r/CBL-Mariner
that referenced
this pull request
Nov 7, 2024
Taken from python/cpython#126185 which is a 3.12 backport of python/cpython#124712 Signed-off-by: Saul Paredes <[email protected]>
Redent0r
added a commit
to Redent0r/CBL-Mariner
that referenced
this pull request
Nov 7, 2024
Taken from python/cpython#126185 which is a 3.12 backport of python/cpython#124712 Signed-off-by: Saul Paredes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch properly quotes template strings in
venvactivation scripts. This mitigates potential command injection.(cherry picked from commit d48cc82)
venvactivation scripts do not quote strings properly #124651