gh-126366: Make native generators thread safe #126371
Open
+92
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @colesbury |
|
I will try to take a look at today :) |
colesbury
reviewed
Nov 4, 2024
ZeroIntensity
changed the title
list.__init__
|
Closing in favor of #120327 |
|
Wait I closed my PR in favour of yours... 😆 @ZeroIntensity |
|
Ah! I'll reopen this and list you as a co-author if yours has merge conflicts. |
| @@ -1104,8 +1104,10 @@ dummy_func( | |||
| (Py_TYPE(receiver_o) == &PyGen_Type || Py_TYPE(receiver_o) == &PyCoro_Type) && | |||
| ((PyGenObject *)receiver_o)->gi_frame_state < FRAME_EXECUTING) | |||
| { | |||
| _PyInterpreterFrame *gen_frame; | |||
There was a problem hiding this comment.
I have a feeling you'll need to fix the specializations too. But right now they aren't enabled, so no way to test them until Matt re-enables them :(.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Ken Jin [email protected]
ChainMapof aCounterin threads #126366