Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-76785: Minor Cleanup of "Cross-interpreter" Code #126457

Merged

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Nov 5, 2024

The primary objective here is to allow some later changes to be cleaner. Mostly this involves renaming things and moving a few things around.

  • *CrossInterpreterData* -> *XIData*
  • crossinterpdatafunc -> xidatafunc
  • split out pycore_crossinterp_data_registry.h
  • add _PyXIData_lookup_t

@ZeroIntensity
Copy link
Member

It looks like most of this is just find and replace renaming, but I can give it a once-over tomorrow if you want a second set of eyes.

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's not much to comment about here--it's all renaming as far as I can tell, and I don't think nitpicking formatting or something like that would be a good use of time :)

@ericsnowcurrently ericsnowcurrently merged commit 9357fdc into python:main Nov 7, 2024
37 checks passed
@ericsnowcurrently ericsnowcurrently deleted the crossinterp-cleanup branch November 7, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants