-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126464 Fix jit build on aarch64 macos #126494
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the impression that gh-126465 fixed the JIT failures, and we're waiting on an upstream fix. Do we need this?
This doesn't seem to fix the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! Awesome, so this probably boils down to a version/path problem...
As a sidenote, I also saw actions/runner-images#10917, which may fix this issue as it removes the newest version of xcode. However, it doesn't hurt to explicitly state SDKROOT
anyway. What's interesting is that when I was building LLVM from source awhile ago, I also had to specify SDKROOT
for newer LLVM to find headers.
Thanks so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One suggestion:
.github/workflows/jit.yml
Outdated
@@ -134,7 +133,7 @@ jobs: | |||
brew install llvm@${{ matrix.llvm }} | |||
SDKROOT="$(xcrun --show-sdk-path)" \ | |||
./configure --enable-experimental-jit ${{ matrix.debug && '--with-pydebug' || '--enable-optimizations --with-lto' }} | |||
make all --jobs 4 | |||
SDKROOT="$(xcrun --show-sdk-path)" make all --jobs 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're doing this on line 134 too, maybe just remove both and put export SDKROOT="$(xcrun --show-sdk-path)"
before the ./configure
step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Done
Updating the
Command Line Tools for Xcode
version in hope it will solve jit build failure on macosaarch64-apple-darwin/clang
JIT CI is broken #126464