Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-126458: disable SIMD for HACL under WASI #126512

Merged
merged 1 commit into from
Nov 6, 2024
Merged

GH-126458: disable SIMD for HACL under WASI #126512

merged 1 commit into from
Nov 6, 2024

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Nov 6, 2024 •
edited by bedevere-app bot
Loading

The *mmintrin.h header files require x86-family CPUs.

@brettcannon brettcannon added type-bug An unexpected behavior, bug, or error build The build process and cross-build labels Nov 6, 2024
@brettcannon brettcannon self-assigned this Nov 6, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 6, 2024
Closed
erlend-aasland
erlend-aasland approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine as a temporary workaround; thanks!

@brettcannon brettcannon merged commit 2a6b6b3 into python:main Nov 6, 2024
49 checks passed
@brettcannon brettcannon deleted the 126458-disable-wasi-hacl-simd branch November 6, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@picnixz picnixz Awaiting requested review from picnixz

Assignees

@brettcannon brettcannon

Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettcannon @erlend-aasland