Skip to content

gh-130195: Remove unimplemented option from pygettext fix typo #130254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+2 −1
Open

gh-130195: Remove unimplemented option from pygettext fix typo #130254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f90318
Wrap line and fix typo
StanFromIreland Feb 18, 2025
168b99c
Wrap
StanFromIreland Feb 18, 2025
12f7532
Update Tools/i18n/pygettext.py
StanFromIreland Apr 4, 2025
9a35485
Merge branch 'main' into fix-typo
StanFromIreland Apr 4, 2025
f53d33f
Merge remote-tracking branch 'origin/fix-typo' into fix-typo
StanFromIreland Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tools-Demos/2025-02-16-19-00-00.gh-issue-130195.19274.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add warning messages when :program:`pygettext` unimplemented ``-a/--extract-all`` option is called.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an improvement? (i.e. it links to the doc page for pygettext)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not checked, it was suggested by @tomasr8 and I believe it is just styling.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is just styling, example ("2to3"):

image

2 changes: 1 addition & 1 deletion Tools/i18n/pygettext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ class Options:
if opt in ('-h', '--help'):
usage(0)
elif opt in ('-a', '--extract-all'):
print("DepreciationWarning: -a/--extract-all is not implemented and will be removed in a future version",
print("DeprecationWarning: -a/--extract-all is not implemented and will be removed in a future version",
file=sys.stderr)
options.extractall = 1
elif opt in ('-c', '--add-comments'):
Expand Down
Loading