Revert "gh-128364: Fix flaky test_timeout test (gh-130724)"
#130732
Merged
+2
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" Change broke Android and iOS buildbots that do not have multiprocessing. This reverts commit cfa0b1d.
colesbury
added
needs backport to 3.12
|
!buildbot Android |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit ffc7ee6 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130732%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
zanieb
approved these changes
Mar 1, 2025
|
It also seems fine to just skip this test on those platforms? per your original comment in #128364 about removing the test entirely. |
|
Yeah, I agree but I'd rather revert now and fix later. |
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 1, 2025
…)" (pythongh-130732) Change broke Android and iOS buildbots that do not have multiprocessing. This reverts commit cfa0b1d. (cherry picked from commit 5221d9c) Co-authored-by: Sam Gross <[email protected]>
|
GH-130734 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 1, 2025
…)" (pythongh-130732) Change broke Android and iOS buildbots that do not have multiprocessing. This reverts commit cfa0b1d. (cherry picked from commit 5221d9c) Co-authored-by: Sam Gross <[email protected]>
|
GH-130735 is a backport of this pull request to the 3.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change broke Android and iOS buildbots that do not have multiprocessing.
This reverts commit cfa0b1d.
test_concurrent_futures.test_wait.ThreadPoolWaitTests.test_timeoutflakes frequently on free-threaded Windows x64 #128364