[3.13] gh-128364: Fix flaky test_concurrent_futures.test_wait tests (gh-130742)
#130922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests (pythongh-130742) Use events instead of relying on `time.sleep()`. The tests are also now about four times faster. (cherry picked from commit c4d37ee) Co-authored-by: Sam Gross <[email protected]>
|
!buildbot refleaks |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 69db40b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130922%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use events instead of relying on
time.sleep(). The tests are also now about four times faster.(cherry picked from commit c4d37ee)
test_concurrent_futures.test_wait.ThreadPoolWaitTests.test_timeoutflakes frequently on free-threaded Windows x64 #128364