gh-130957: Use sleeping_retry in test_free_reference
#130958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The weak reference may not be immediately dead.
vstinner
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
LGTM.
I managed to reproduce the issue using #130957 (comment) patch. I confirm that this change fix the issue.
colesbury
added
needs backport to 3.12
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 11, 2025
…nGH-130958) The weak reference may not be immediately dead. (cherry picked from commit 1908115) Co-authored-by: Sam Gross <[email protected]>
|
GH-131091 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 11, 2025
…nGH-130958) The weak reference may not be immediately dead. (cherry picked from commit 1908115) Co-authored-by: Sam Gross <[email protected]>
|
GH-131092 is a backport of this pull request to the 3.12 branch. |
colesbury
added a commit
that referenced
this pull request
Mar 11, 2025
…30958) (#131092) The weak reference may not be immediately dead. (cherry picked from commit 1908115) Co-authored-by: Sam Gross <[email protected]>
colesbury
added a commit
that referenced
this pull request
Mar 11, 2025
…30958) (#131091) The weak reference may not be immediately dead. (cherry picked from commit 1908115) Co-authored-by: Sam Gross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The weak reference may not be immediately dead.
test_concurrent_futures:test_free_referenceis flaky #130957